fix(vm): fix external module resolve error with deps optimizer query for encoded URI by SveLil · Pull Request #10658 · vitest-dev/vitest

SveLil · 2026-06-24T12:19:04Z

Description

Resolves #10657

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

Run the tests with pnpm test:ci

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

SveLil · 2026-06-24T12:20:16Z

Note: This is only a fix for ONE cleanUrl, there are quite a few, maybe time for a cleanup?

sheremet-va · 2026-06-24T15:24:30Z

Why does vm receive an encoded string when cleaning the URL? Is it passed down incorrectly?

hi-ogawa

The only source of glitch seems like the single point here in getCachedVitestImport

vitest/packages/vitest/src/runtime/moduleRunner/cachedResolver.ts

Line 30 in a60ded0

: pathToFileURL(id).toString()

so fix belongs there and not the general cleanUrl side.

Unfortunately, we get ?v=xxx only when vitest is inside node_modules so that seems like the reason we don't repro in our e2e.

SveLil · 2026-06-25T06:59:10Z

I just debugged, for me it's a few lines later:

vitest/packages/vitest/src/runtime/moduleRunner/cachedResolver.ts

Line 40 in a60ded0

const externalize = pathToFileURL(path).toString()

I'll push the fix soon.

netlify · 2026-06-25T07:03:24Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`2aa1237`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/6a3cd26ae875be00085aa325
😎 Deploy Preview	https://deploy-preview-10658--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa · 2026-06-25T07:18:21Z

    const externalize = id.startsWith('file://')
      ? id
-      : pathToFileURL(id).toString()
+      : decodeURIComponent(pathToFileURL(id).toString())


From what I can guess, the idea isn't decoding. The idea is to have pathToFileURL to not include ?param by splitting id so it aligns with the fix on consumer side #10024.

Perhaps something like this here and below.

const { file, postfix } = splitFileAndPostfix(id) const externalize = id.startsWith('file://') ? id : `${pathToFileURL(file)}${postfix}`

No problem at all, that works, too

Pushed a version that will include the param but returns a non-encoded URI

pkg-pr-new · 2026-06-25T07:19:53Z

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@630c027

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@630c027

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@630c027

@vitest/browser-webdriverio

npm i https://pkg.pr.new/@vitest/browser-webdriverio@630c027

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@630c027

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@630c027

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@630c027

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@630c027

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@630c027

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@630c027

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@630c027

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@630c027

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@630c027

vitest

npm i https://pkg.pr.new/vitest@630c027

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@630c027

commit: 630c027

hi-ogawa

Thank you!
I verified the repro with pkg.pr.new. Not being able to e2e is unfortunate but can be revisited in the future.

hi-ogawa · 2026-06-25T09:28:22Z

This means vm + optimizer has been broken entire v4 phase. We may want to backport this to v4.

SveLil · 2026-06-25T09:41:21Z

This means vm + optimizer has been broken entire v4 phase. We may want to backport this to v4.

Yes, I'm on v4 and I will backport it

sheremet-va · 2026-06-25T10:25:01Z

Please, backport to v4 branch

SveLil · 2026-06-25T10:44:37Z

See #10661 10661

hi-ogawa requested changes Jun 25, 2026

View reviewed changes

SveLil added a commit to SveLil/vitest that referenced this pull request Jun 25, 2026

fix(vm): fix cachedResolver encoding URIs (fix vitest-dev#10658)

2aa1237

SveLil force-pushed the main branch from 6a14411 to 2aa1237 Compare June 25, 2026 07:02

hi-ogawa requested changes Jun 25, 2026

View reviewed changes

hi-ogawa added the cr-tracked label Jun 25, 2026

SveLil added a commit to SveLil/vitest that referenced this pull request Jun 25, 2026

fix(vm): fix cachedResolver encoding URIs (fix vitest-dev#10658)

ae04538

SveLil force-pushed the main branch from 2aa1237 to ae04538 Compare June 25, 2026 07:37

fix(vm): fix cachedResolver encoding URIs (fix vitest-dev#10658)

630c027

SveLil force-pushed the main branch from ae04538 to 630c027 Compare June 25, 2026 07:45

hi-ogawa approved these changes Jun 25, 2026

View reviewed changes

hi-ogawa requested a review from sheremet-va June 25, 2026 09:27

SveLil added a commit to SveLil/vitest that referenced this pull request Jun 25, 2026

fix(vm): fix cachedResolver encoding URIs (fix vitest-dev#10658)

6508d96

sheremet-va approved these changes Jun 25, 2026

View reviewed changes

sheremet-va merged commit 90c4ed4 into vitest-dev:main Jun 25, 2026
19 checks passed

hi-ogawa mentioned this pull request Jun 26, 2026

fix(vm): fix external module resolve error with deps optimizer query for encoded URI [backport to v4] #10661

Open

6 tasks

Uh oh!

Uh oh!

Conversation

SveLil commented Jun 24, 2026

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Uh oh!

SveLil commented Jun 24, 2026

Uh oh!

sheremet-va commented Jun 24, 2026

Uh oh!

hi-ogawa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SveLil commented Jun 25, 2026

vitest/packages/vitest/src/runtime/moduleRunner/cachedResolver.ts Line 40 in a60ded0 const externalize = pathToFileURL(path).toString()

Uh oh!

netlify Bot commented Jun 25, 2026

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

SveLil Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

SveLil Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hi-ogawa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hi-ogawa commented Jun 25, 2026

Uh oh!

SveLil commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sheremet-va commented Jun 25, 2026

Uh oh!

SveLil commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hi-ogawa left a comment •

edited

Loading

vitest/packages/vitest/src/runtime/moduleRunner/cachedResolver.ts

Line 40 in a60ded0

const externalize = pathToFileURL(path).toString()

pkg-pr-new Bot commented Jun 25, 2026 •

edited

Loading

hi-ogawa left a comment •

edited

Loading

SveLil commented Jun 25, 2026 •

edited

Loading