Skip to content

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 15, 2024

Description

This is a backport of #15254

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Merge Conflict Skip CI Skip CI actions from running Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Feb 15, 2024
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Feb 15, 2024

Hello @frouioui, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 15262 -R vitessio/vitess
git reset --hard origin/release-17.0
git cherry-pick -m 1 096b8a828b402961d914e1c565c5b4f4e72a0c88

@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Feb 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v17.0.6 milestone Feb 15, 2024
@frouioui frouioui removed Skip CI Skip CI actions from running Merge Conflict labels Feb 15, 2024
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the backport-15254-to-release-17.0 branch from 53e5ac8 to eb58d59 Compare February 15, 2024 23:04
@frouioui frouioui marked this pull request as ready for review February 15, 2024 23:04
@frouioui frouioui requested a review from mattlord as a code owner February 15, 2024 23:04
@frouioui frouioui merged commit fb28fc0 into release-17.0 Feb 16, 2024
@frouioui frouioui deleted the backport-15254-to-release-17.0 branch February 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants