Skip to content

fix: graceful rename in windows #8036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2022
Merged

fix: graceful rename in windows #8036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/src/node/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,8 +775,8 @@ function gracefulRename(
) {
setTimeout(function () {
fs.stat(to, function (stater, st) {
if (stater && stater.code === 'ENOENT') gracefulRename(from, to, CB)
else cb(er)
if (stater && stater.code === 'ENOENT') fs.rename(from, to, CB)
Copy link
Member Author

@patak-dev patak-dev May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a mistake when doing the translation to our code, see:
https://github.com/isaacs/node-graceful-fs/blob/1f19b0b467e4144260b397343cd60f37c5bdcfda/polyfills.js#L109

else CB(er)
Copy link
Member Author

@patak-dev patak-dev May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a bug on node-graceful-fs. If the code isn't 'ENOENT', it means the directory still exists and we should keep retrying. So we need to call CB. Calling cb ends the recursion returning the original error.

Copy link
Member

@bluwy bluwy May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. This makes sense to me too after catching the flow.

})
}, backoff)
if (backoff < 100) backoff += 10
Expand Down