chore: format & check with prettier#5869
Merged
patak-cat merged 1 commit intovitejs:mainfrom Nov 28, 2021
jeffydc:check-format
Merged
chore: format & check with prettier#5869patak-cat merged 1 commit intovitejs:mainfrom jeffydc:check-format
patak-cat merged 1 commit intovitejs:mainfrom
jeffydc:check-format
Conversation
patak-cat
approved these changes
Nov 28, 2021
Member
|
Prettier is also not working properly for me on commit (Windows 10), @Shinigami92 do you have any pointers for us to check? |
Contributor
Author
|
Suggestion though: should we switch to husky? |
Contributor
Author
I think the root cause is |
Member
I'll bring this to the next team's meeting, yorkie is now more than 500+ commits behind husky 👍🏼 |
Shinigami92
reviewed
Nov 28, 2021
packages/playground/html/unicode-path/中文-にほんご-한글-🌕🌖🌗/index.html
Outdated
Show resolved
Hide resolved
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ran prettier formatting and add a CI step for prettier formatting checking.
Additional context
Somehow, yorkie doesn't trigger git hooks
commit-msgandpre-commit. Maybe it could only happen on my machine.So, I sent a separate PR not to add noise in #5868
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).