Skip to content

chore: format & check with prettier#5869

Merged
patak-cat merged 1 commit intovitejs:mainfrom
jeffydc:check-format
Nov 28, 2021
Merged

chore: format & check with prettier#5869
patak-cat merged 1 commit intovitejs:mainfrom
jeffydc:check-format

Conversation

@jeffydc
Copy link
Contributor

@jeffydc jeffydc commented Nov 28, 2021

Description

Ran prettier formatting and add a CI step for prettier formatting checking.

Additional context

Somehow, yorkie doesn't trigger git hooks commit-msg and pre-commit. Maybe it could only happen on my machine.
So, I sent a separate PR not to add noise in #5868


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat
Copy link
Member

Prettier is also not working properly for me on commit (Windows 10), @Shinigami92 do you have any pointers for us to check?

@jeffydc
Copy link
Contributor Author

jeffydc commented Nov 28, 2021

Suggestion though: should we switch to husky?

@jeffydc
Copy link
Contributor Author

jeffydc commented Nov 28, 2021

Prettier is also not working properly for me on commit (Windows 10), @Shinigami92 do you have any pointers for us to check?

I think the root cause is yorkie which is used to trigger git hooks, but actually it doesn't.

@patak-cat
Copy link
Member

Suggestion though: should we switch to husky?

I'll bring this to the next team's meeting, yorkie is now more than 500+ commits behind husky 👍🏼

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Nov 28, 2021
@patak-cat patak-cat merged commit c344865 into vitejs:main Nov 28, 2021
@jeffydc jeffydc deleted the check-format branch November 28, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants