feat: allow ?worker&url to only get the worker url#5845
Closed
DrJume wants to merge 1 commit intovitejs:mainfrom
DrJume:main
Closed
feat: allow ?worker&url to only get the worker url#5845DrJume wants to merge 1 commit intovitejs:mainfrom DrJume:main
DrJume wants to merge 1 commit intovitejs:mainfrom
DrJume:main
Conversation
9 tasks
Member
|
Thanks for the PR. Closing as it is implemented by #7914. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows you to import a worker with
import worker from './foo?worker&url', but instead of returning a worker constructor it returns the url directly.This is needed for using a Service Worker or a custom wrapper like Workbox.
Using
import worker from './foo?url'works, but it does not transform (minify) the code or applies vite'sdefinemacros.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).