feat(plugin-legacy): add externalSystemJS option#5024
Merged
patak-cat merged 1 commit intovitejs:mainfrom Sep 24, 2021
Merged
Conversation
Shinigami92
added
p2-nice-to-have
antfu
approved these changes
Sep 24, 2021
Member
antfu
left a comment
antfu
left a comment
There was a problem hiding this comment.
LGTM. I will bring this to this week's meeting with the team.
yyx990803
approved these changes
Sep 24, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling this option will exclude
systemjs/dist/s.min.jsinside polyfills-legacy chunk. It's useful in Micro Frontends case I think.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).