-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(cli): add Node.js version warning for unsupported versions #20638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sapphi-red
merged 8 commits into
main
from
copilot/fix-7afe18c9-f745-44c6-882f-67332ea8db14
Aug 19, 2025
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
438d725
Initial plan
Copilot 0ca7060
Add Node.js version warning to Vite CLI
Copilot fa0ff09
refactor(cli): return boolean from checkNodeVersion function
Copilot 06e320c
refactor(cli): use console.warn and move warning outside checkNodeVer…
Copilot 758b37d
refactor(cli): use parameter for node version and table-based tests
Copilot 103e2e4
chore: update
sapphi-red 1981efc
chore: update
sapphi-red 5e40ad4
chore: format
sapphi-red File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { describe, expect, test } from 'vitest' | ||
| import { checkNodeVersion } from '../cli' | ||
|
|
||
| describe('CLI Node.js version checking', () => { | ||
| test.each([ | ||
| // Unsupported versions | ||
| ['18.20.0', false], | ||
| ['20.18.5', false], | ||
| ['22.11.0', false], | ||
| // Supported versions | ||
| ['20.19.0', true], | ||
| ['20.20.1', true], | ||
| ['22.12.0', true], | ||
| ['22.13.1', true], | ||
| ['23.0.0', true], | ||
| ])('should return %p for Node.js version %s', (version, expected) => { | ||
| const result = checkNodeVersion(version) | ||
| expect(result).toBe(expected) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.