Skip to content

fix: merge old and new noExternal: true correctly #20502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

fix: merge old and new noExternal: true correctly #20502

merged 2 commits into from
Aug 5, 2025

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jul 30, 2025

@hi-ogawa hi-ogawa marked this pull request as ready for review July 30, 2025 23:18
@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Aug 5, 2025
@sapphi-red sapphi-red merged commit 9ebe4a5 into vitejs:main Aug 5, 2025
17 checks passed
@hi-ogawa hi-ogawa deleted the fix-new-old-noExternal-true branch August 5, 2025 05:34
@jamesopstad jamesopstad mentioned this pull request Aug 26, 2025
Closed
@hi-ogawa hi-ogawa mentioned this pull request Nov 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ssr.noExternal and environments.ssr.resolve.noExternal are not merged correctly

2 participants

@hi-ogawa @sapphi-red