Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

Follow up to #19418

Now that CustomPluginOptions type is an interface (rollup/rollup#5850), we can extend it by declaration merging.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 3, 2025
@sapphi-red sapphi-red added this to the 6.3 milestone Mar 3, 2025
patak-dev
patak-dev previously approved these changes Mar 3, 2025
bluwy
bluwy previously approved these changes Mar 3, 2025
@sapphi-red sapphi-red dismissed stale reviews from bluwy and patak-dev via 476a3a1 March 19, 2025 10:57
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 19, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite@19557

commit: 4057714

@vite-ecosystem-ci
Copy link

@sapphi-red
Copy link
Member Author

sapphi-red commented Mar 19, 2025

Since this PR breaks types in ecosystem-ci (because of the rollup version mismatch), probably better to merge this one later.

@sapphi-red sapphi-red changed the title feat: expose CustomPluginOptionsVite type feat(types): expose CustomPluginOptionsVite type Mar 26, 2025
@sapphi-red sapphi-red merged commit 15abc01 into vitejs:main Mar 26, 2025
25 of 26 checks passed
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
@sapphi-red sapphi-red deleted the feat/expose-custom-plugin-options-vite-type branch August 6, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority) trigger: preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants