fix(css): resolve style tags in HTML files correctly for lightningcss #19001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: css
p3-minor-bug
sapphi-red
commented
Dec 18, 2024
| test('inline css modules', async () => { | ||
| const css = await page.textContent('.modules-inline') | ||
| expect(css).toMatch(/\.\w{6}_apply-color-inline/) | ||
| expect(css).toMatch(/\._?\w{6}_apply-color-inline/) |
Member
Author
There was a problem hiding this comment.
lightningcss adds _ if the hash started with digits.
https://github.com/parcel-bundler/lightningcss/blob/master/src/css_modules.rs#L543-L544
patak-dev
previously approved these changes
Dec 18, 2024
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
Nice! I think we can merge this one without splitting.
sapphi-red
force-pushed
the
fix/css-lightning-css
branch
from
63391ee to
90afd3a
Compare
Member
Author
|
I rebased on main branch (instead of merging) to resolve the conflicts while keeping the commits. |
patak-dev
approved these changes
Dec 18, 2024
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 26, 2024
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 6.0.5 | 6.0.6 | ## [v6.0.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small606-2024-12-26-small) - fix: replace runner-side path normalization with `fetchModule`-side resolve ([#18361](vitejs/vite#18361)) ([9f10261](vitejs/vite@9f10261)), closes [#18361](vitejs/vite#18361) - fix(css): resolve style tags in HTML files correctly for lightningcss ([#19001](vitejs/vite#19001)) ([afff05c](vitejs/vite@afff05c)), closes [#19001](vitejs/vite#19001) - fix(css): show correct error when unknown placeholder is used for CSS modules pattern in lightningcs ([9290d85](vitejs/vite@9290d85)), closes [#19070](vitejs/vite#19070) - fix(resolve): handle package.json with UTF-8 BOM ([#19000](vitejs/vite#19000)) ([902567a](vitejs/vite@902567a)), closes [#19000](vitejs/vite#19000) - fix(ssrTransform): preserve line offset when transforming imports ([#19004](vitejs/vite#19004)) ([1aa434e](vitejs/vite@1aa434e)), closes [#19004](vitejs/vite#19004) - chore: fix typo in comment ([#19067](vitejs/vite#19067)) ([eb06ec3](vitejs/vite@eb06ec3)), closes [#19067](vitejs/vite#19067) - chore: update comment about `build.target` ([#19047](vitejs/vite#19047)) ([0e9e81f](vitejs/vite@0e9e81f)), closes [#19047](vitejs/vite#19047) - revert: unpin esbuild version ([#19043](vitejs/vite#19043)) ([8bfe247](vitejs/vite@8bfe247)), closes [#19043](vitejs/vite#19043) - test(ssr): test virtual module with query ([#19044](vitejs/vite#19044)) ([a1f4b46](vitejs/vite@a1f4b46)), closes [#19044](vitejs/vite#19044)
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
\0included infilenameoption is treated as a character terminator parcel-bundler/lightningcss#874projectRootoption to make the code a bit simpler^1.21.0so we can use it.I'll split the PR if needed.