fix(ssr): hoist export to handle cyclic import better

[hi-ogawa]

Description

• closes Vite SSR Imports not loading classes correctly - constructors not loaded #14048

Currently Object.defineProperty(__vite_ssr_exports__, ...) is not hoisted and this is different from what bundlers normally do (see my notes in https://github.com/hi-ogawa/reproductions/tree/main/cyclic-import). By defining __vite_ssr_exports__ property early before await __vite_ssr_import__(...) calls, it fixes certain cyclic import scenarios.

For export * from "...", bundlers statically analyze the export names and hoist them too, but this is not possible for Vite SSR, so __vite_ssr_exportAll__ is kept as is.

One potential issue with this change is that this can technically break a "working" code with cyclic import which were previously forgiven. This was actually the case of our own unit test. See #18983 (comment) for details.

todo

• fix broken unit-tests with bad cyclic import entry
  • go with setupFiles: ['./packages/vite/src/node/index.ts'] trick
• compare with rollup output
  • https://github.com/hi-ogawa/reproductions/tree/main/vite-18983-rollup-cyclic-import
  • should work similar to this PR
• review ecosystem failure
  • vitest: broken source map? (the issue is on Vitest side test: debug Vite PR 18983 vitest-dev/vitest#7096)
  • vitest: broken coverage Missing function coverage when transform prepends code right before the function vitest-dev/vitest#7130
    • this could be a blocker. we probably need some judgement from Ari.
    • this doesn't happen if we ensure ;\n when hoisting, but that would entirely diminish the effort of fix(ssrTransform): preserve line offset when transforming imports #19004
    • Now giving up line preservation to ensure Vitest coverage won't get easily broken. The initial motivation of line-preservation was for broken debugging on Vitest, but that is separately fixed on Vitest side by fix(vite-node): fix source map of inlined node_modules vitest-dev/vitest#7557

[hi-ogawa]

/ecosystem-ci run

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/vite@18983

commit: 7e7b660

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 3cc86da: Open

suite	result	latest scheduled
histoire	❌ failure	❌ failure
laravel	❌ failure	✅ success
marko	❌ failure	✅ success
nuxt	❌ failure	✅ success
redwoodjs	❌ failure	❌ failure
remix	❌ failure	❌ failure
vike	❌ failure	❌ failure
vite-plugin-svelte	❌ failure	❌ failure
vitest	❌ failure	✅ success
waku	❌ failure	❌ failure

✅ analogjs, astro, ladle, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

[hi-ogawa]

Interestingly, export hoisting can make cyclic import handling stricter as seen by:

$ pnpm test-unit packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts 

FAIL  packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts [ packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts ]
ReferenceError: Cannot access 'serverConfigDefaults' before initialization
 ❯ Module.get [as serverConfigDefaults] packages/vite/src/node/server/index.ts:4:116

but this case might be legitimate since this is the same error as tsx:

$ pnpm exec tsx packages/vite/src/node/server/index.ts
/home/hiroshi/code/others/vite/packages/vite/src/node/config.ts:648
  server: serverConfigDefaults,
          ^


ReferenceError: Cannot access 'serverConfigDefaults' before initialization

I'd imagine previously these were undefined (still wrong but no hard error) since __vite_ssr_import_x_.serverConfigDefaults getter was not defined. But now this hits uninitialized const serverConfigDefaults access due to getter.

Just temporarily, I added this silly setupFiles, so that modules will be initialized in a known safe order.

[hi-ogawa]

It turns out the error now became same as playground/hmr but module runner doesn't auto-reload, so the existing test failed.

 ReferenceError: Cannot access 'c' before initialization

I adjust this test case for now to make it pass.

[hi-ogawa]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 83a7a1f: Open

suite	result	latest scheduled
histoire	❌ failure	❌ failure
ladle	❌ failure	❌ failure
nuxt	✅ success	❌ failure
redwoodjs	❌ failure	❌ failure
remix	❌ failure	❌ failure
vite-plugin-svelte	❌ failure	❌ failure
vitest	❌ failure	❌ failure
waku	❌ failure	❌ failure

✅ analogjs, astro, laravel, marko, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vike, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 83a7a1f: Open

suite	result	latest scheduled
histoire	❌ failure	❌ failure
ladle	❌ failure	❌ failure
nuxt	✅ success	❌ failure
redwoodjs	❌ failure	❌ failure
remix	❌ failure	❌ failure
vite-plugin-svelte	❌ failure	❌ failure
vitest	❌ failure	❌ failure
waku	❌ failure	❌ failure

✅ analogjs, astro, laravel, marko, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vike, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

[hi-ogawa]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 7e7b660: Open

suite	result	latest scheduled
sveltekit	❌ failure	✅ success
vite-plugin-cloudflare	❌ failure	✅ success
astro	❌ failure	✅ success
vitest	❌ failure	✅ success
vite-plugin-svelte	✅ success	❌ failure

✅ ladle, histoire, previewjs, nuxt, analogjs, marko, qwik, react-router, storybook, vite-plugin-react, vite-environment-examples, laravel, quasar, vite-plugin-pwa, vite-plugin-react-swc, unocss, vite-setup-catalogue, vite-plugin-vue, vitepress, waku, vike, vuepress, rakkas

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 7e7b660: Open

suite	result	latest scheduled
vite-plugin-svelte	✅ success	❌ failure
sveltekit	❌ failure	✅ success
vitest	❌ failure	✅ success
vite-plugin-cloudflare	❌ failure	✅ success

✅ histoire, quasar, react-router, vite-environment-examples, previewjs, qwik, storybook, analogjs, vike, nuxt, vite-plugin-react-swc, rakkas, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-vue, ladle, laravel, marko, astro, waku, vite-setup-catalogue, vitepress, vuepress

[hi-ogawa]

This looks good on Vitest side as confirmed in vitest-dev/vitest#7621