chore: bump typescript-eslint to v8 #17624
Conversation
|
|
| '@typescript-eslint/no-empty-object-type': [ | ||
| 'error', | ||
| { allowInterfaces: 'with-single-extends' }, // maybe we should turn this on in a new PR | ||
| ], |
There was a problem hiding this comment.
@typescript-eslint/ban-types is now split into a few rules: https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta#replacement-of-ban-types
| '@typescript-eslint/no-inferrable-types': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', // maybe we should turn this on in a new PR | ||
| '@typescript-eslint/no-var-requires': 'off', | ||
| '@typescript-eslint/no-require-imports': 'off', |
There was a problem hiding this comment.
@typescript-eslint/no-var-requires was merged into @typescript-eslint/no-require-imports: typescript-eslint/typescript-eslint#8092
| 'no-extra-semi': 'off', | ||
| '@typescript-eslint/no-extra-semi': 'off', // conflicts with prettier | ||
| '@typescript-eslint/no-inferrable-types': 'off', | ||
| '@typescript-eslint/no-unused-expressions': 'off', // maybe we should turn this on in a new PR |
There was a problem hiding this comment.
@typescript-eslint/no-unused-expressions was promoted to the recommended config in v8.
| ): ResultPromise<EO & (keyof EO extends 'stdio' ? {} : { stdio: 'inherit' })> { | ||
| ): ResultPromise< | ||
| EO & (keyof EO extends 'stdio' ? object : { stdio: 'inherit' }) | ||
| > { |
There was a problem hiding this comment.
https://v8--typescript-eslint.netlify.app/rules/ban-types: this is now covered by @typescript-eslint/no-empty-object-type. This particular object is better described as object, I think.
|
The changes look great to me. I personally don't mind trying the beta here. Is there anything else you plan to do as it's in draft? |
Nothing while we're still in beta. Once we release as stable -tentatively in a week!- I was going to bump the version to stable & un-draft this & other beta testing PRs. |
|
Awesome! Looking forward to the release |
|
This can be changed from draft now since typescript-eslint 8 got released right? @JoshuaKGoldberg @bluwy |
|
In |
That sounds very reasonable and good to me, but I'm not a maintainer on this project and this PR is just an internal chore. Sounds like a good feature request / suggestion to file separately! |
antfu
left a comment
antfu
left a comment
There was a problem hiding this comment.
Otherwise LGTM, thanks for the explanations!
Co-authored-by: Anthony Fu <[email protected]>
|
I'll merge this in for now. Re |
5 participants
Description
👋 Hi! Coming over from typescript-eslint/typescript-eslint#9141: we're working on typescript-eslint v8 and would like to try the beta out on repos like this one.
I'm sending this draft PR as a reference to see what issues we might give you in upgrading and to try to be helpful. If this is annoying noise to you, please forgive me, I'll withdraw the PR. But I hope this is useful on your end - and please let me know if you have any feedback! ❤️
I've put inline comments on any changes. There shouldn't be anything user-facing (this isn't a
feat:orfix:PR).