Skip to content

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Jun 14, 2024

Description

fix #17466

We didn't handle the case for syntax like this.

const foo = (await import('foo')).foo, bar = ...

The trailing comma was incorrectly captured by the regex. I updated it to capture the .foo part properly.


I also added additional handling for leading commas:

const foo = ..., { bar } = await import('bar')

I adjusted the first portion of the regex to accommodate it.

@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Jun 14, 2024
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member Author

bluwy commented Jun 14, 2024

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 950c8f3: Open

suite result latest scheduled
analogjs failure success
histoire success failure
nuxt failure failure
vite-plugin-react-pages failure failure
vite-setup-catalogue success failure
vitest failure failure

astro, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vitepress

@bluwy
Copy link
Member Author

bluwy commented Jun 14, 2024

The analog fail seems to be a build issue due to recent changes on their end. The last passing run was two days ago.

@patak-dev
Copy link
Member

Thanks for the quick fix! Looks good to me ❤️

@patak-dev patak-dev merged commit 3e27071 into main Jun 14, 2024
@patak-dev patak-dev deleted the dynamic-import-fix branch June 14, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p4-important Violate documented behavior or significantly improves performance (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: vite 5.3.0 fails ionic build command

3 participants