-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat: improve dynamic import variable failure error message #16519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve dynamic import variable failure error message #16519
Conversation
|
|
|
I think in general, we want to hide IIUC the issue is that some may forgot that |
|
It makes sense, I just noticed that the document states Maybe we can add |
|
I think maybe directly appending The link currently doesn't have a lot of information, so might not be worth adding it for now. |
bluwy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work locally for me 👍 Curious to hear what others think of this extra code added before merging it.
patak-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the added param. Another option is to add a link that is always there and explain more in the docs. Or reword it as a tip but it may confuse more than it helps.
|
Maybe we can add a detailed explanation chapter about this situation to the |
Description
As shown in the figure below, when the dynamic import component fails, the error message
Unknown variable dynamic import: ./components/a/b/test.vuewill appear.But judging from the code structure, there is no problem with the path. I think this information may not be enough for people to immediately and clearly determine where the problem occurs, so outputting pattern information may be able to explain the problem more clearly and help users locate the problem more quickly.