Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 15, 2024

Description

Added @shikijs/vitepress-twoslash so that users can hover the code to know the types. I didn't add to some code blocks for those I thought it will be distracting.
https://deploy-preview-16168--vite-docs-main.netlify.app/guide/api-javascript.html#build

BTW it was really easy to add this. It's awesome.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Mar 15, 2024
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 🤌

@patak-dev
Copy link
Member

Woah... this looks so good 😍

@patak-dev patak-dev merged commit 6f8a320 into vitejs:main Mar 15, 2024
@sapphi-red sapphi-red deleted the docs/add-shikijs-vitepress-twoslash branch March 15, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants