Skip to content

Conversation

@XiSenao
Copy link
Collaborator

@XiSenao XiSenao commented Feb 22, 2024

Description

fix: #15851
ref: #15619

Additional context

In Rollup, in general, namespace import objects do not extend properties on the prototype chain.

import * as paper from 'paper/dist/paper-core';
const { Color } = paper;
const w = paper;
// true
console.log(Color=== w.Color);
// false
console.log(Color === paper.Color);

However, in the above use cases, it seems that rollup intentionally allows access to properties on the prototype chain. The behavior looks a bit strange, so let's temporarily close the current PR until we figure out the truth of the matter.
ref: rollup/rollup#5403


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception is not a constructor since Vite 5.1.0

1 participant