Skip to content

fix: optimizeDeps.entries with literal-only pattern(s) #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-dev merged 3 commits into from
Feb 21, 2024
Merged

fix: optimizeDeps.entries with literal-only pattern(s) #15853

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
399fdcd
fix: optimizeDeps.entries with literal-only pattern(s)
Jinjiang Feb 9, 2024
61687b0
fix: dynamic pattern detector for optimizeDeps.entries
Jinjiang Feb 10, 2024
0a56639
fix: reuse arraify to handle optimizeDeps.entires
Jinjiang Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/node/optimizer/scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ function orderedDependencies(deps: Record<string, string>) {
}

function globEntries(pattern: string | string[], config: ResolvedConfig) {
const resolvedPatterns = Array.isArray(pattern) ? pattern : [pattern]
if (resolvedPatterns.every((str) => !glob.isDynamicPattern(str))) {
return resolvedPatterns.map((p) => path.resolve(config.root, p))
}
return glob(pattern, {
cwd: config.root,
ignore: [
Expand Down