Skip to content

fix: check the existence of "document" before using it #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: check the existence of "document" before using it #15262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f789202
Check the existence of "document" before using it
mike-lischke Dec 6, 2023
92a4c1d
Return a value even if no document is available
mike-lischke Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/vite/src/client/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,18 +281,27 @@ function notifyListeners(event: string, data: any): void {
}

const enableOverlay = __HMR_ENABLE_OVERLAY__
const hasDocument = typeof document !== 'undefined'

function createErrorOverlay(err: ErrorPayload['err']) {
clearErrorOverlay()
document.body.appendChild(new ErrorOverlay(err))
if (hasDocument) {
document.body.appendChild(new ErrorOverlay(err))
}
}

function clearErrorOverlay() {
document.querySelectorAll<ErrorOverlay>(overlayId).forEach((n) => n.close())
if (hasDocument) {
document.querySelectorAll<ErrorOverlay>(overlayId).forEach((n) => n.close())
}
}

function hasErrorOverlay() {
return document.querySelectorAll(overlayId).length
if (hasDocument) {
return document.querySelectorAll(overlayId).length
}

return false
}

let pending = false
Expand Down Expand Up @@ -378,7 +387,7 @@ const sheetsMap = new Map<string, HTMLStyleElement>()

// collect existing style elements that may have been inserted during SSR
// to avoid FOUC or duplicate styles
if ('document' in globalThis) {
if (hasDocument) {
document
.querySelectorAll<HTMLStyleElement>('style[data-vite-dev-id]')
.forEach((el) => {
Expand Down