Skip to content

docs(legacy): clarify that csp hashes could change between minors#15057

Merged
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:docs-legacy-csp-minor
Nov 21, 2023
Merged

docs(legacy): clarify that csp hashes could change between minors#15057
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:docs-legacy-csp-minor

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

#15021 (comment)

Additional context

Should we mention that pinning the version isn't needed if you are getting the value from import { cspHashes } from '@vitejs/plugin-legacy'?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation plugin: legacy labels Nov 21, 2023
@patak-cat
Copy link
Copy Markdown
Member

Should we mention that pinning the version isn't needed if you are getting the value from import { cspHashes } from '@vitejs/plugin-legacy'?

This sounds like a good idea to me 👍🏼

@sapphi-red
Copy link
Copy Markdown
Member Author

Tried to include that pinning is not necessary when using cspHashes. I'm not sure if the text is clear.

@patak-cat
Copy link
Copy Markdown
Member

This reads very well, and it is a good justification as to why we don't consider the changes in the hashes a breaking change

@patak-cat patak-cat merged commit cd35330 into vitejs:main Nov 21, 2023
@sapphi-red sapphi-red deleted the docs-legacy-csp-minor branch November 21, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation plugin: legacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants