feat: add off method to ViteHotContext (issue #14185)#14518
Merged
bluwy merged 3 commits intovitejs:mainfrom Oct 11, 2023
Merged
feat: add off method to ViteHotContext (issue #14185)#14518bluwy merged 3 commits intovitejs:mainfrom
bluwy merged 3 commits intovitejs:mainfrom
Conversation
bluwy
reviewed
Oct 3, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
The implementation looks great. Can we add a test for it around
Lines 107 to 115 in 56c5f4f
vite/playground/hmr/__tests__/hmr.spec.ts
Lines 174 to 183 in 56c5f4f
(new test cases, but those are existing examples)
sapphi-red
reviewed
Oct 9, 2023
Member
sapphi-red
left a comment
There was a problem hiding this comment.
bluwy
approved these changes
Oct 10, 2023
patak-cat
approved these changes
Oct 10, 2023
9 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr adds the ability to remove listeners added using import.meta.hot.on() as
requested in issue #14185
fix #14185
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).