Conversation
unbuild to bundle plugins
bluwy
reviewed
May 12, 2022
sapphi-red
approved these changes
May 13, 2022
Member
|
@antfu Was it ok to merge this? (in case, didn't notice the auto-merge) |
Member
Author
|
I guess it should be fine :) |
Member
|
Also partially reviewed this yesterday and it looks good as well. |
Contributor
|
I believe this broke I'm using vite.config.js inside a project where package.json is using Previous working → New non-working: |
9 tasks
Member
|
@bompus Thanks for the report. |
9 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
unbuildto bundle and generate DTS (due to the complexity, leave the bundle of core untouched)exportsfield (probably breaking)plugin-vue-jsxandplugin-legacyto TypeScriptbuild-vite,build-plugin-*scripts are removed.pnpm run builduses pnpm's recursive runs to build them together.patchEsbuildDistis removed in favor ofpatchCJSdevscript to run all watch build at once.