Skip to content

fix: disable hot reloading if in a WebWorker #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnaudBarre merged 2 commits into from
Jun 19, 2023
Merged

fix: disable hot reloading if in a WebWorker #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ede39a6
Disable hot reloading if in a WebWorker
siefkenj Jun 16, 2023
29863fa
Add webwork check to footer code
siefkenj Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/plugin-react/src/fast-refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ window.__vite_plugin_react_preamble_installed__ = true
const header = `
import RefreshRuntime from "${runtimePublicPath}";

const inWebWorker = typeof WorkerGlobalScope !== 'undefined' && self instanceof WorkerGlobalScope;
let prevRefreshReg;
let prevRefreshSig;

if (import.meta.hot) {
if (import.meta.hot && !inWebWorker) {
if (!window.__vite_plugin_react_preamble_installed__) {
throw new Error(
"@vitejs/plugin-react can't detect preamble. Something is wrong. " +
Expand All @@ -51,7 +52,7 @@ if (import.meta.hot) {
}`.replace(/\n+/g, '')

const footer = `
if (import.meta.hot) {
if (import.meta.hot && !inWebWorker) {
window.$RefreshReg$ = prevRefreshReg;
window.$RefreshSig$ = prevRefreshSig;

Expand Down