forked from vitejs/vite
-
-
Notifications
You must be signed in to change notification settings - Fork 17
Using Rolldown with Vite v6 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d231ee to
2087832
Compare
259bd2a to
6af67ee
Compare
|
FYI,
this is by design, if use customResolver in native plugin, there is no performance difference between |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
066d276 to
04c717f
Compare
Closed
2f09b9c to
66201d6
Compare
db6e5bd to
504ad37
Compare
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Migrated to #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied changes from #24 and #27 to the main branch after the environment API PR is merged.
Also fixed errors on Windows and cleaned up some unneeded changes.
#24 implemented build-time dep optimization partially, but I didn't include that change in this PR.
e2e test status
missing feature list that was supported by esbuild / rollup
options.watchwatcher.on('event', listener)shouldTransformCachedModule,watchChange,closeWatcherthis.addWatchFilesystemformatoptions.attributesforresolveIdhookresolveImportMetahook: can usetransformhook for Vite's usecaseoptions.preserveEntrySignatures: not necessary but nice for smaller bundlesnative plugin incompatibilities
customResolveroptionplayground/backend-integration, you can see the manifest not containingcssandassetsfield inindex.html.intended behavior differences
definedoes not share reference for objects oxc-project/oxc#7641requireis never transformed intoimport, users needs to inject a polyfill on their own, see f4c3629TODO list for me
filterin hooksfilterin hooks