Skip to content

fix(pallet-pass): update benchmarks for new device filter signatures

0bc92fb
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

feat(pallet-pass): per-device call filters #71

fix(pallet-pass): update benchmarks for new device filter signatures
0bc92fb
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Apr 3, 2026 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.94.1 (e408947bf 2026-03-25)
  • cargo 1.94.1 (29ea6fb6a 2026-03-24)
  • clippy 0.1.94 (e408947bfd 2026-03-25)

Annotations

Check warning on line 25 in pallets/communities/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`
  --> pallets/communities/src/benchmarking.rs:25:49
   |
25 |     frame_system::Pallet::<T>::assert_has_event(generic_event.into());
   |                                                 ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 91 in pallets/orders/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<<<T as pallet::Config<I>>::BenchmarkHelper as types::benchmarks::BenchmarkHelper<T, I>>::Balances as frame_support::traits::fungible::Inspect<<T as frame_system::Config>::AccountId>>::Balance`

warning: useless conversion to the same type: `<<<T as pallet::Config<I>>::BenchmarkHelper as types::benchmarks::BenchmarkHelper<T, I>>::Balances as frame_support::traits::fungible::Inspect<<T as frame_system::Config>::AccountId>>::Balance`
  --> pallets/orders/src/benchmarking.rs:91:79
   |
91 |     <T::BenchmarkHelper as BenchmarkHelper<T, I>>::Balances::mint_into(owner, amount.into())?;
   |                                                                               ^^^^^^^^^^^^^ help: consider removing `.into()`: `amount`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion

Check warning on line 11 in pallets/orders/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`
  --> pallets/orders/src/benchmarking.rs:11:49
   |
11 |     frame_system::Pallet::<T>::assert_has_event(generic_event.into());
   |                                                 ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 400 in pallets/pass/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> pallets/pass/src/lib.rs:400:52
    |
400 |             Devices::<T, I>::contains_key(address, &caller_device_id),
    |                                                    ^^^^^^^^^^^^^^^^^ help: change this to: `caller_device_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrows_for_generic_args

Check warning on line 117 in pallets/pass/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> pallets/pass/src/extensions.rs:117:63
    |
117 |             let filter = DeviceFilters::<T, I>::get(&address, &params.device_id)
    |                                                               ^^^^^^^^^^^^^^^^^ help: change this to: `params.device_id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 9 in pallets/listings/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`
 --> pallets/listings/src/benchmarking.rs:9:49
  |
9 |     frame_system::Pallet::<T>::assert_has_event(generic_event.into())
  |                                                 ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
  = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 47 in pallets/pass/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> pallets/pass/src/filter.rs:47:57
   |
47 | pub struct AssetSpendLimit<AssetId: Clone + Debug + Eq, Balance: Clone + Debug + Eq> {
   |                                                         ^^^^^^^
48 |     pub asset: AssetId,
49 |     pub max_amount: Balance,
   |                     ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#multiple_bound_locations

Check warning on line 47 in pallets/pass/src/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> pallets/pass/src/filter.rs:47:28
   |
47 | pub struct AssetSpendLimit<AssetId: Clone + Debug + Eq, Balance: Clone + Debug + Eq> {
   |                            ^^^^^^^
48 |     pub asset: AssetId,
   |                ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 6 in pallets/template/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as frame_system::Config>::RuntimeEvent`
 --> pallets/template/src/benchmarking.rs:6:50
  |
6 |     frame_system::Pallet::<T>::assert_last_event(generic_event.into());
  |                                                  ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
  = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 6 in pallets/black-hole/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as polkadot_sdk_frame::prelude::frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as polkadot_sdk_frame::prelude::frame_system::Config>::RuntimeEvent`
 --> pallets/black-hole/src/benchmarking.rs:6:50
  |
6 |     frame_system::Pallet::<T>::assert_last_event(generic_event.into());
  |                                                  ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
  = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 34 in pallets/gas-transaction-payment/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `<T as polkadot_sdk_frame::prelude::frame_system::Config>::RuntimeEvent`

warning: useless conversion to the same type: `<T as polkadot_sdk_frame::prelude::frame_system::Config>::RuntimeEvent`
  --> pallets/gas-transaction-payment/src/benchmarking.rs:34:50
   |
34 |     frame_system::Pallet::<T>::assert_last_event(generic_event.into());
   |                                                  ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `generic_event`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default