Adds support for Google Secrets Manager#25
Merged
willroberts merged 14 commits intomasterfrom Jul 8, 2025
Merged
Conversation
Collaborator
sergiosalvatore
left a comment
sergiosalvatore
left a comment
There was a problem hiding this comment.
A couple small things... Otherwise, looks good!
Co-authored-by: Sergio Salvatore <sergiosalvatore@users.noreply.github.com>
willroberts
force-pushed
the
add-gsm-support
branch
2 times, most recently
from
d43cd41 to
90dcaf2
Compare
Collaborator
sergiosalvatore
left a comment
sergiosalvatore
left a comment
There was a problem hiding this comment.
nice -- one last small thing.
sergiosalvatore
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSM secrets can now be included by specifying a mapping with
sourceType: gsm:This maintains backward compatibility by assuming a Vault
sourceTypeunless explicitly specified.This PR also updates documentation, and upgrades Go from v1.18 to v1.24.