More SV-comp fixes #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBMC has changed the representation of numerical values in constant_expr (at least for array sizes) - instead of base 2, it now uses base 16. We have to fix this in our assertion that limits the size of arrays in competition mode due to solver unsoundness that appears for arrays of size >=50000.
For now, we disable memcpy as it is implemented via a CBMC built-in operation that we do not support in 2LS, yet.
Signed-off-by: František Nečas <[email protected]>
If there are multiple loops in the program, the assertions after the loops are reachable only if both of the loops exit their execution. Previously, exiting the first loop was sufficient due to the disjunction making the analysis unsound (producing incorrect true results in some cases, including SV-comp benchmarks). Signed-off-by: František Nečas <[email protected]>
The format of the guard changed making the hack not work and causing incorrect true results in bitvector category in SV-comp due to the hoisted assertion being added. Fix this hack. Signed-off-by: František Nečas <[email protected]>
Author
|
The submodule will also have to be updated, see the last commit in peterschrammel/cbmc#27 |
viktormalik
force-pushed
the
svcomp22-fixes
branch
from
e52a02a to
b775692
Compare
Owner
|
Merged into diffblue#157 manually, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 3 more SV-comp related fixes:
ID_overflow_shlis no longer produced, check if it contains overflowing shift left manually (fixes incorrect true bitvector overflow tests).I am not sure what's the best way to merge it, maybe rebase through Github rather than merging to avoid merge commit? Or simply cherry-pick my commits to your branch...