Better privacy through local hosting of JS and fonts#76
Merged
etix merged 7 commits intovideolabs:masterfrom Nov 5, 2018
Merged
Better privacy through local hosting of JS and fonts#76etix merged 7 commits intovideolabs:masterfrom
etix merged 7 commits intovideolabs:masterfrom
Conversation
Google charts does not permit offline or selfhosted use. If you want to use it, you HAVE to consign your users to googles disgusting everpresent tracking, and that seems a bit of a high price to pay for just displaying a simple pie chart.
…e local copies of JavaScript files instead of external CDNs that will violate users privacy through tracking.
…tiles in mirrorlist.html.
Note: This will also update the version of fontawesome used in the non-local case from 4.1.0 to 4.7.0 for consistency (because 4.1.0 is not available for download anymore).
Contributor
|
Nice PR. However I wonder whether this project is still being maintained seeing the last commit was 9 months ago? @etix |
Collaborator
|
I'll allocate some time next week to review this and maybe plan a new release. |
Collaborator
|
Thanks for your great contribution! Few remarks:
Beside that seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it convenient to host the Javascript and Fonts used by the default templates locally, so there is no need to use external third-party CDNs that can (and will) track your users.
It consists of
As long as LocalJSPath is not set, the templates will behave as before, loading stuff from Google/cloudflare/bootstrapcdn, because of course, this makes initial setup easier for new users. There are however two unavoidable changes to before in that case, in order to keep consistency between locally hosted and not-locally hosted: