Switch mirrorlist to use OSM instead of Google Maps#74
Merged
etix merged 2 commits intovideolabs:masterfrom Feb 6, 2018
Merged
Switch mirrorlist to use OSM instead of Google Maps#74etix merged 2 commits intovideolabs:masterfrom
etix merged 2 commits intovideolabs:masterfrom
Conversation
Collaborator
|
Thanks! I'll review that today. |
Collaborator
|
Great work. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated version of PR #72
This switches the mirrorlist-template to use a map based on OSM with leaflet (javascript) instead of a image generated through Googles Maps API.
As the mirrorlist-template was the only place where GMaps was used (the mirrorstatus-template already used OSM), we can now also remove the GoogleMapsAPIKey from the config. The function for generating the URL to the image, GetMirrorMapURL(), isn't needed anymore either, and neither is the test for that function.