Skip to content

Conversation

@mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Nov 13, 2024

Description

Fixes that Escape being pressed isn't closing menus due to incorrect event.key name.
Fixes #8915

Specific Changes proposed

Replaces Esc with Escape.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (ecef37c) to head (43f431a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/js/menu/menu-button.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8916      +/-   ##
==========================================
+ Coverage   83.25%   83.43%   +0.18%     
==========================================
  Files         120      120              
  Lines        8097     8097              
  Branches     1944     1944              
==========================================
+ Hits         6741     6756      +15     
+ Misses       1356     1341      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit d0cf139 into videojs:main Nov 14, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some checks for Escape key use incorrect value

2 participants