Review Improvements#29
Merged
claravanstaden merged 13 commits intovgeddes:snowbridge-v2from Mar 5, 2025
Merged
Conversation
…bridge-pallet-inbound-queue-v2-fixtures.
vgeddes
reviewed
Mar 4, 2025
Owner
There was a problem hiding this comment.
actually the latest feedback from Parity is that we shouldnt be adding our pallets to the umbrella crate at all.
Collaborator
Author
There was a problem hiding this comment.
Excludes snowbridge crates here: b33ed0c#diff-18d38928be81628d2fd67bb9fe76fb785e84ee8f057b0501d99089888fe46ae7
franciscoaguirre
approved these changes
Mar 4, 2025
# Conflicts: # Cargo.lock # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/bridge_to_ethereum_config.rs
Collaborator
Author
|
@vgeddes I have addressed most of Cisco's comments here, with the following outstanding:
I would like to do the benchmarks in a follow-up PR. |
|
Review required! Latest push from author must always be reviewed |
yrong
reviewed
Mar 4, 2025
vgeddes
reviewed
Mar 4, 2025
bridges/snowbridge/primitives/outbound-queue/src/v2/converter/tests.rs
Outdated
Show resolved
Hide resolved
Collaborator
|
There are some compile issues when I run these commands: format issue: Please fix the issues, otherwise all looks good to me. |
vgeddes
approved these changes
Mar 4, 2025
# Conflicts: # bridges/snowbridge/pallets/outbound-queue-v2/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed @franciscoaguirre's PR comments from comment paritytech#7402 (comment) downward.