feat: add more services #33
Closed
+3,460
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
Signed-off-by: Tadas Sutkaitis <[email protected]>
mnaser
requested changes
Nov 4, 2025
Member
mnaser
left a comment
mnaser
left a comment
There was a problem hiding this comment.
round 1, can you do the splits for the resources like the other ones please?
Comment on lines
+41
to
+42
| openstack_glance_image_bytes{id="1bea47ed-f6a9-463b-b423-14b9cca9ad27",name="cirros-0.3.2-x86_64-disk",tenant_id="5ef70662f8b34079a6eddb8da9d75fe8"} 1.3167616e+07 | ||
| openstack_glance_image_bytes{id="781b3762-9469-4cec-b58d-3349e5de4e9c",name="F17-x86_64-cfntools",tenant_id="5ef70662f8b34079a6eddb8da9d75fe8"} 4.76704768e+08 |
Member
There was a problem hiding this comment.
I think upstream tests have these flipped, I've wanted to try and keep them identical. Would it work to flip them?
Comment on lines
+26
to
+32
| -- name: GetImageCount :one | ||
| SELECT | ||
| COUNT(*) as count | ||
| FROM | ||
| images | ||
| WHERE | ||
| deleted = 0; No newline at end of file |
Member
There was a problem hiding this comment.
This query is neve used, so let's remove/drop it :)
Member
There was a problem hiding this comment.
Can you "massage" this to be similar to the other ones like how it has no keys and constraints and the primary key is on the field itself?
| } | ||
|
|
||
| for _, image := range images { | ||
| // Convert size from nullable int64 to float64, defaulting to 0 if null |
Member
There was a problem hiding this comment.
We can drop this comment, it's pretty clear :)
| keystonedb "github.com/vexxhost/openstack_database_exporter/internal/db/keystone" | ||
| ) | ||
|
|
||
| const Subsystem = "identity" |
Member
There was a problem hiding this comment.
Can you move this to keystone.go?
Comment on lines
+42
to
+63
| groupsDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(collector.Namespace, Subsystem, "groups"), | ||
| "groups", | ||
| nil, | ||
| nil, | ||
| ) | ||
|
|
||
| projectInfoDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(collector.Namespace, Subsystem, "project_info"), | ||
| "project_info", | ||
| []string{ | ||
| "description", | ||
| "domain_id", | ||
| "enabled", | ||
| "id", | ||
| "is_domain", | ||
| "name", | ||
| "parent_id", | ||
| "tags", | ||
| }, | ||
| nil, | ||
| ) |
Comment on lines
+65
to
+70
| projectsDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(collector.Namespace, Subsystem, "projects"), | ||
| "projects", | ||
| nil, | ||
| nil, | ||
| ) |
Comment on lines
+72
to
+77
| regionsDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(collector.Namespace, Subsystem, "regions"), | ||
| "regions", | ||
| nil, | ||
| nil, | ||
| ) |
Comment on lines
+79
to
+84
| usersDesc = prometheus.NewDesc( | ||
| prometheus.BuildFQName(collector.Namespace, Subsystem, "users"), | ||
| "users", | ||
| nil, | ||
| nil, | ||
| ) |
| func NewIdentityCollector(db *sql.DB, logger *slog.Logger) *IdentityCollector { | ||
| return &IdentityCollector{ | ||
| db: db, | ||
| logger: logger, |
Member
There was a problem hiding this comment.
queries can live here so you dont have to call every function with it
Contributor
Author
|
@mnaser I splitted everything to separate PRs + added some changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.