Update Ingress Template

[todpunk]

I present this as a suggestion, and it will:

• Update the ingress to remove the second path that conflicts in Traefik 2.x and I assume other ingress controllers that are more strict about their matching.
• Update the deprecated apiVersion for this K8s object and leave an option for backwards compatibility for those that are on older kubernetes versions.

I am running this in production currently and it seems to work with the second ingress path disabled and the new api version. I have added comments to the values file for posterity.

Would you like anything changed on this?

[kav]

Any reason not to just remove the second path? I don't know that it's adding any value there. Does anyone have a use case that calls for it? nginx definitely doesn't need it and it's currently non-idomatic. I've not run across a need for a /* route for any of the ingress controllers or seen it in any other charts

[todpunk]

I do not know every ingress controller. I have seen a kubernetes-dashboard chart have multiple paths: https://github.com/kubernetes/dashboard/blob/master/aio/deploy/helm-chart/kubernetes-dashboard/templates/ingress.yaml

As pointed out, it is more idiomatic to have that parsed out. I left it the way I had to maintain compatibility if anyone else is using it currently.

[todpunk]

I'm going to modify this really quickly to match the dashboard chart I linked, as I think I can make that flexible for either "default" we want to carry forward. Uno momento.

[todpunk]

That should be more akin to the example of the kubernetes-dashboard chart now. Paths and hosts are also separated so hosts is not necessarily required to use the ingress.

[juanpicado]

Thanks @todpunk 💯