Skip to content

font/google test: update cssmodule classnames #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

font/google test: update cssmodule classnames #3568

merged 1 commit into from
Feb 1, 2023
+2 −4

Conversation

@wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Feb 1, 2023

#3437 wasn't up to date with main when it was merged.

Test Plan: CI

@wbinnssmith wbinnssmith requested a review from a team as a code owner February 1, 2023 01:36
@wbinnssmith wbinnssmith requested a review from kwonoj February 1, 2023 01:37
@vercel
Copy link
Contributor

vercel bot commented Feb 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 1, 2023 at 1:37AM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 1:37AM (UTC)

@wbinnssmith wbinnssmith added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 1, 2023
@wbinnssmith wbinnssmith merged commit 7018c3f into main Feb 1, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/update-font-test-cssmodules branch February 1, 2023 02:04
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Benchmark for 2432b2c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9967.73µs ± 93.04µs 10.06ms ± 0.10ms +0.94%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.22ms ± 0.09ms 10.35ms ± 0.08ms +1.34%
bench_hmr_to_commit/Turbopack RSC/1000 modules 504.12ms ± 3.19ms 505.44ms ± 4.41ms +0.26%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.04ms ± 0.11ms 10.04ms ± 0.09ms +0.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8941.10µs ± 88.01µs 8986.02µs ± 88.53µs +0.50%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9198.82µs ± 55.61µs 9190.59µs ± 75.07µs -0.09%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9111.63µs ± 77.71µs 9166.83µs ± 50.17µs +0.61%
bench_hydration/Turbopack RCC/1000 modules 3953.29ms ± 19.76ms 3933.14ms ± 25.32ms -0.51%
bench_hydration/Turbopack RSC/1000 modules 3451.50ms ± 16.36ms 3465.74ms ± 17.02ms +0.41%
bench_hydration/Turbopack SSR/1000 modules 3180.19ms ± 13.58ms 3165.23ms ± 14.54ms -0.47%
bench_startup/Turbopack CSR/1000 modules 2140.16ms ± 13.21ms 2135.08ms ± 9.85ms -0.24%
bench_startup/Turbopack RCC/1000 modules 2596.76ms ± 11.45ms 2599.20ms ± 11.15ms +0.09%
bench_startup/Turbopack RSC/1000 modules 2492.30ms ± 14.14ms 2488.59ms ± 12.35ms -0.15%
bench_startup/Turbopack SSR/1000 modules 2118.40ms ± 12.08ms 2105.69ms ± 9.83ms -0.60%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Rust tests
  • Rust benchmark tests

See workflow summary for details

mehulkar pushed a commit that referenced this pull request Feb 1, 2023
@wbinnssmith @mehulkar
font/google test: update cssmodule classnames (#3568)
82ff652 
#3437 wasn't up to date with main when it was merged.

Test Plan: CI
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@wbinnssmith
font/google test: update cssmodule classnames (vercel/turborepo#3568)
2e6c11e 
#3437 wasn't up to date with main when it was merged.

Test Plan: CI
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@wbinnssmith
font/google test: update cssmodule classnames (vercel/turborepo#3568)
1b2a240 
#3437 wasn't up to date with main when it was merged.

Test Plan: CI
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@wbinnssmith
font/google test: update cssmodule classnames (vercel/turborepo#3568)
8c25edd 
vercel/turborepo#3437 wasn't up to date with main when it was merged.

Test Plan: CI
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
font/google test: update cssmodule classnames (vercel/turborepo#3568)
48ad8c1 
vercel/turborepo#3437 wasn't up to date with main when it was merged.

Test Plan: CI
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@wbinnssmith
font/google test: update cssmodule classnames (vercel/turborepo#3568)
2e29aaa 
vercel/turborepo#3437 wasn't up to date with main when it was merged.

Test Plan: CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kwonoj kwonoj kwonoj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: automerge Kodiak will merge these automatically after checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wbinnssmith @kwonoj