Skip to content

Conversation

@samuel871211
Copy link
Contributor

@samuel871211 samuel871211 commented Jan 26, 2025

Problem

The TSDoc for PublicConfiguration.onDiscarded is inconsistent with the description on the SWR official website.

Changes

Updated TSDoc to match the SWR official website:

  • Original: callback function when a request is ignored
  • Updated: callback function when a request is ignored due to race conditions

Related Issues

#2979

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@samuel871211 samuel871211 changed the title doc: tsdoc for PublicConfiguration.onDiscarded doc: Sync PublicConfiguration.onDiscarded tsdoc with official documentation Feb 9, 2025
@samuel871211 samuel871211 changed the title doc: Sync PublicConfiguration.onDiscarded tsdoc with official documentation doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official documentation Feb 9, 2025
@samuel871211 samuel871211 changed the title doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official documentation doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official website Feb 9, 2025
@shuding shuding merged commit 5f708b7 into vercel:main Jul 19, 2025
3 checks passed
@samuel871211 samuel871211 deleted the tsDocImprove branch July 20, 2025 04:13
dcondrey pushed a commit to dcondrey/swr that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants