Skip to content

[dev-overlay] Polish mobile view #78863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devjiwonchoi merged 1 commit into from
May 6, 2025
Merged

[dev-overlay] Polish mobile view #78863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/next/src/client/components/react-dev-overlay/ui/components/dialog/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ const styles = `
transition: opacity var(--transition-duration) var(--timing-overlay);
}

[data-nextjs-dialog-overlay] {
margin: 8px;
}

[data-nextjs-dialog-overlay][data-rendered='true']
[data-nextjs-dialog-backdrop] {
opacity: 1;
Expand Down
43 changes: 33 additions & 10 deletions ...components/react-dev-overlay/ui/components/errors/error-overlay-nav/error-overlay-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export function ErrorOverlayNav({

export const styles = `
[data-nextjs-error-overlay-nav] {
--stroke-color: var(--color-gray-400);
--background-color: var(--color-background-100);
display: flex;
justify-content: space-between;
align-items: center;
Expand All @@ -56,25 +58,22 @@ export const styles = `
position: relative;
z-index: 2;
outline: none;
translate: 1px 1px;
translate: var(--next-dialog-border-width) var(--next-dialog-border-width);
max-width: var(--next-dialog-max-width);

.error-overlay-notch {
--stroke-color: var(--color-gray-400);
--background-color: var(--color-background-100);

translate: -1px 0;
translate: calc(var(--next-dialog-border-width) * -1);
width: auto;
height: var(--next-dialog-notch-height);
padding: 12px;
background: var(--background-color);
border: 1px solid var(--stroke-color);
border: var(--next-dialog-border-width) solid var(--stroke-color);
border-bottom: none;
position: relative;

&[data-side='left'] {
padding-right: 0;
border-radius: var(--rounded-xl) 0 0 0;
border-radius: var(--next-dialog-radius) 0 0 0;

.error-overlay-notch-tail {
right: -54px;
Expand All @@ -87,7 +86,7 @@ export const styles = `

&[data-side='right'] {
padding-left: 0;
border-radius: 0 var(--rounded-xl) 0 0;
border-radius: 0 var(--next-dialog-radius) 0 0;

.error-overlay-notch-tail {
left: -54px;
Expand All @@ -101,10 +100,34 @@ export const styles = `

.error-overlay-notch-tail {
position: absolute;
top: -1px;
top: calc(var(--next-dialog-border-width) * -1);
pointer-events: none;
z-index: -1;
height: calc(100% + 1px);
height: calc(100% + var(--next-dialog-border-width));
}
}
}

@media (max-width: 600px) {
[data-nextjs-error-overlay-nav] {
background: var(--background-color);
border-radius: var(--next-dialog-radius) var(--next-dialog-radius) 0 0;
border: var(--next-dialog-border-width) solid var(--stroke-color);
border-bottom: none;
overflow: hidden;
translate: 0 var(--next-dialog-border-width);

.error-overlay-notch {
border-radius: 0;
border: 0;

&[data-side="left"], &[data-side="right"] {
border-radius: 0;
}

.error-overlay-notch-tail {
display: none;
}
}
}
}
Expand Down
Loading