-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add onLoadingComplete() prop to Image component
#26824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
264404f
Add `onLoadingComplete()` prop to Image component
styfle 2f423ce
Revise handleLoading()
styfle c37f413
Add test
styfle f1e1b69
Add docs and warning
styfle 520639b
Add loading placeholder in the test
styfle 57a4fc3
Merge branch 'canary' into 18398-on-loading-complete
ijjk bb6918b
mention the placeholder has been removed
styfle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
test/integration/image-component/default/pages/on-loading-complete.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { useState } from 'react' | ||
| import Image from 'next/image' | ||
|
|
||
| const Page = () => ( | ||
| <div> | ||
| <h1>On Loading Complete Test</h1> | ||
| <ImageWithMessage id="1" src="/test.jpg" /> | ||
| <ImageWithMessage | ||
| id="2" | ||
| src={require('../public/test.png')} | ||
| placeholder="blur" | ||
| /> | ||
| </div> | ||
| ) | ||
|
|
||
| function ImageWithMessage({ id, src }) { | ||
| const [msg, setMsg] = useState('[LOADING]') | ||
| return ( | ||
| <> | ||
| <Image | ||
| id={`img${id}`} | ||
| src={src} | ||
| width="400" | ||
| height="400" | ||
| onLoadingComplete={() => setMsg(`loaded img${id}`)} | ||
| /> | ||
| <p id={`msg${id}`}>{msg}</p> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| export default Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.