Build Crash on Windows (`TypeError`) for `_isAppDir`

[ovflowd]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

Binaries:
  Node: 18.13.0
  npm: 9.6.7
  Yarn: 1.22.19
  pnpm: 8.6.0
Relevant packages:
  next: 13.4.5
  eslint-config-next: 13.4.5
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.1.3

Which area(s) of Next.js are affected? (leave empty if unsure)

Operating System (Windows, MacOS, Linux)

Link to the code that reproduces this issue or a replay of the bug

nodejs/nodejs.org#5426

To Reproduce

The Issue actually happens within GitHub Actions on a Windows Runner. And seems to be fine on Linux and macOS builds. It seems to be related to "app directory" even thought we do not use the "app directory feature"

Describe the Bug

build: TypeError: Cannot read properties of undefined (reading '_isAppDir')
build:     at D:\a\nodejs.org\nodejs.org\node_modules\next\dist\export\index.js:420:39
build:     at Array.filter (<anonymous>)
build:     at D:\a\nodejs.org\nodejs.org\node_modules\next\dist\export\index.js:419:43
build:     at async Span.traceAsyncFn (D:\a\nodejs.org\nodejs.org\node_modules\next\dist\trace\trace.js:103:20)
build:     at async D:\a\nodejs.org\nodejs.org\node_modules\next\dist\build\index.js:1489:21
build:     at async Span.traceAsyncFn (D:\a\nodejs.org\nodejs.org\node_modules\next\dist\trace\trace.js:103:20)
build:     at async D:\a\nodejs.org\nodejs.org\node_modules\next\dist\build\index.js:1345:17
build:     at async Span.traceAsyncFn (D:\a\nodejs.org\nodejs.org\node_modules\next\dist\trace\trace.js:103:20)
build:     at async build (D:\a\nodejs.org\nodejs.org\node_modules\next\dist\build\index.js:145:[29](https://github.com/nodejs/nodejs.org/actions/runs/5253121230/jobs/9490043267?pr=5426#step:7:30))
build: ERROR: command finished with error: command (D:\a\nodejs.org\nodejs.org) npm run build exited (1)
command (D:\a\nodejs.org\nodejs.org) npm run build exited (1)

GitHub Action: https://github.com/nodejs/nodejs.org/actions/runs/5253121230/jobs/9490043267?pr=5426

Expected Behavior

The build should succeed as in the other systems (Linux, macOS).

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

_NEXT-1504

[ovflowd]

Hey @styfle sorry for the ping! We're still seeing this in our CI!

I.e.: https://github.com/nodejs/nodejs.org/actions/runs/5806595272/job/15739809537?pr=5617

[styfle]

@ovflowd I tried building that repo using Windows 11 and it works fine.

I created PR #53818 with a potential fix but it would be good to get the steps to reproduce.

I suspect it might have something to do with this experimental feature so you could try disabling that: https://github.com/nodejs/nodejs.org/blob/25717d37e28243cbfbc5910d80c7c8459026220b/next.config.mjs#L51-L53

[ovflowd]

I suspect it might have something to do with this experimental feature so you could try disabling that: nodejs/nodejs.org@25717d3/next.config.mjs#L51-L53

I remember I had to add that due to a momentary bug on Next.js that it was including SWC binaries within the Edge Runtimes, which was causing the runtimes to exceed the max 50mb size... Is that fixed?

[ovflowd]

I created PR #53818 with a potential fix but it would be good to get the steps to reproduce.

Super appreciate the PR! Also, @bmuenzenmeyer was facing this on his Windows 11 machine.

[bmuenzenmeyer]

I get this error on the nodejs repo, at the tip of current development.

For example, from nodejs/nodejs.org@9a45ee1

git clone git@github.com:nodejs/nodejs.org.git node-site
cd node-site
nvm use
npm ci
npx turbo deploy

if you have a canary build handy, you can directly install it here to verify. I tried to decipher from this github action if next makes canaries on each pr, I saw a reference to next 13.4.14-canary.1 - but I think that's pointing to a released canary and the line is symlinking to the local checkout. installing that version still presents the error

error output

/c/src/nodejsorg-4 (main) 🔥 npx turbo deploy
• Running deploy
• Remote caching disabled
deploy: cache miss, executing 463091786f71314b
deploy: 
deploy: > nodejs.org@1.0.0 deploy
deploy: > cross-env NEXT_STATIC_EXPORT=true npm run build
deploy: 
deploy: 
deploy: > nodejs.org@1.0.0 prebuild
deploy: > npm run scripts:generate-next-data
deploy: 
deploy: 
deploy: > nodejs.org@1.0.0 scripts:generate-next-data
deploy: > cross-env NODE_NO_WARNINGS=1 node scripts/generate-next-data/index.mjs
deploy: 
deploy: 
deploy: > nodejs.org@1.0.0 build
deploy: > cross-env NODE_NO_WARNINGS=1 next build
deploy: 
deploy: - warn You have enabled experimental features (largePageDataBytes, outputFileTracingExcludes) in next.config.mjs.
deploy: - warn Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use at your own risk.
deploy: 
deploy: - info Creating an optimized production build...
deploy: - info Compiled successfully
deploy: - info Skipping validation of types
deploy: - info Skipping linting
deploy: - info Collecting page data...
deploy: 
deploy: > Build error occurred
deploy: TypeError: Cannot read properties of undefined (reading '_isAppDir')
deploy:     at C:\src\nodejsorg-4\node_modules\next\dist\export\index.js:422:39
deploy:     at Array.filter (<anonymous>)
deploy:     at C:\src\nodejsorg-4\node_modules\next\dist\export\index.js:421:43
deploy:     at async Span.traceAsyncFn (C:\src\nodejsorg-4\node_modules\next\dist\trace\trace.js:103:20)
deploy:     at async C:\src\nodejsorg-4\node_modules\next\dist\build\index.js:1597:21
deploy:     at async Span.traceAsyncFn (C:\src\nodejsorg-4\node_modules\next\dist\trace\trace.js:103:20)
deploy:     at async C:\src\nodejsorg-4\node_modules\next\dist\build\index.js:1453:17
deploy:     at async Span.traceAsyncFn (C:\src\nodejsorg-4\node_modules\next\dist\trace\trace.js:103:20)
deploy:     at async build (C:\src\nodejsorg-4\node_modules\next\dist\build\index.js:148:29)
deploy: ERROR: command finished with error: command (C:\src\nodejsorg-4) npm run deploy exited (1)
deploy: command (C:\src\nodejsorg-4) npm run deploy exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    27.172s
Failed:    //#deploy

 ERROR  run failed: command  exited (1)

happy to provide more debug data

npx next info
(node:22328) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

    Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Pro
    Binaries:
      Node: 18.13.0
      npm: N/A
      Yarn: N/A
      pnpm: 7.26.0
    Relevant Packages:
      next: 13.4.14-canary.1
      eslint-config-next: 13.4.12
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A

[ovflowd]

@bmuenzenmeyer can you format your error output on a "markdown code block"?