-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: embedding model middleware #9437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is there a a reason it is implement for |
Contributor
Author
Contributor
Author
|
Hi @lgrammel do i need to make this middleware support for |
Collaborator
|
Thanks @0xlakshan I'll take it from here and will make a few changes. V2 support is not desired since it would mean changing the provider package for v2. |
packages/provider/src/embedding-model-middleware/v3/embedding-model-v3-middleware.ts
Outdated
Show resolved
Hide resolved
lgrammel
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There is currently no middleware for embedding models, which would be useful for e.g. setting defaults (see #7947 ).
Summary
This PR adds a middleware wrapEmbeddingModel, making it easier to customize and extend embedding model behavior from unified central space.
This also adds support for defaultEmbeddingSettingsMiddleware middleware, letting users manage things like dimensions and provider options from single central place.
Example
Manual Verification
examples/ai-core/src/middleware/embedding/google-default-settings.tsChecklist
pnpm changesetin the project root)pnpm prettier-fixin the project root)Related Issues
Fixes #7947