fix: rename ARM_CCA scheme to CCA for consistency #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Requesting re-review and approval for PR #346 from SIR @setrofim , @yogeshbdeshpande , @thomas-fossati @cowbon .. |
- Renamed directory from scheme/arm-cca to scheme/cca - Updated scheme name from ARM_CCA to CCA - Updated all package names from arm_cca to cca - Updated all import paths and references - Updated plugin names and binaries - Updated test data and integration tests - Updated documentation and README files This addresses the consistency feedback from PR reviewer that CCA scheme should not have vendor prefix like other schemes. Signed-off-by: Kallal Mukherjee <[email protected]>
- Move shebang to first line to fix SC1128 error - Add proper quoting to variable in sqlite3 command to fix SC2086 error Addresses shellcheck violations found during bash script review. Signed-off-by: Kallal Mukherjee <[email protected]>
7908837174
force-pushed
the
plugin-naming-clean
branch
from
9ed1847 to
21d4ba1
Compare
Author
|
Requesting re-review and approval for PR #355 from sir @setrofim , sir @yogeshbdeshpande , sir @thomas-fossati , sir @cowbon .. |
yogeshbdeshpande
requested changes
Oct 10, 2025
Collaborator
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
Arm CCA is a specific scheme, the name reflects the implementation.
Other CCA Schemes may appear in future.
The name Arm CCA is originated from:
https://developer.arm.com/documentation/den0127/300/Introduction/Arm-CCA-goals?lang=en
- Renamed scheme/cca back to scheme/arm-cca - Reverted package name from 'cca' to 'arm_cca' - Restored SchemeName constant to 'ARM_CCA' - Updated import paths and references throughout codebase - Addressed @yogeshbdeshpande review feedback that ARM CCA is a specific scheme and the name should reflect the implementation Signed-off-by: Kallal Mukherjee <[email protected]>
7908837174
force-pushed
the
plugin-naming-clean
branch
from
a6c8ab4 to
68618dc
Compare
Author
|
Requesting re-review and approval for PR #355 from sir @setrofim , sir @yogeshbdeshpande , sir @thomas-fossati , sir @cowbon .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR addresses the naming consistency feedback from the previous plugin naming scheme PR.
Main Changes
Additional Fixes
Rationale
As noted by @setrofim in the review feedback: both "ARM CCA" and "PSA IoT" are Arm schemes, so it's inconsistent that only one has the vendor prefix. For consistency, the CCA scheme should be renamed to just "CCA" since no other scheme has a vendor prefix.
Testing
This addresses issue #123 (plugin naming scheme) and the consistency feedback from PR reviewers.
Fixes #123
Closes #346