Pr 338 BUG #350
Closed
Pr 338 BUG #350
+65
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add URLSafeNonce type with custom JSON marshaling/unmarshaling - Update ChallengeResponseSession to use URLSafeNonce instead of []byte - Update test cases to use URL-safe base64 encoded nonces - Add comprehensive test to verify URL-safe base64 encoding - Ensure nonces no longer contain '+' and '/' characters This resolves the issue where session nonces were encoded using standard base64 instead of URL-safe base64, making them unsuitable for URL parameters and other web contexts. Signed-off-by: Kallal Mukherjee <[email protected]>
…e64 for PSA tokens - PSA evidence token generation (evcli psa create) expects standard base64 nonces - Server now returns URL-safe base64 nonces in challenge-response sessions - Added conversion from URL-safe to standard base64 for PSA claims generation - Matches existing conversion logic already used for CCA tokens - Resolves 'illegal base64 data' errors in integration tests Signed-off-by: Kallal Mukherjee <[email protected]>
Fixes veraison#42. When attestation schemes return empty reference value IDs, the GetAttestation method now skips them before calling kvstore.Get() to avoid 'the supplied key is empty' errors. This commonly occurs when no software components are provisioned in trust anchors, causing handlers to return []string{""} for missing software reference IDs. Signed-off-by: Kallal Mukherjee <[email protected]>
…root cause fix - Remove empty reference ID filtering from VTS GetAttestation method as requested by reviewer @setrofim - Apply root cause fix: modify scheme handlers to return nil instead of []string{""} on errors - Restore detailed error reporting for integrity validation failures - Keep URL-safe base64 nonce functionality which is the valid part of this PR This addresses the reviewer feedback that empty reference IDs should never occur and indicates an upstream bug that should be fixed at the source.
…cheme handlers, preserve URL-safe base64 nonces
As requested by @setrofim, empty reference IDs should never occur, and if they do, it's a bug that should be fixed at the source, not suppressed in the processing loop. This change removes the workaround that was skipping empty reference IDs and allows the system to fail properly if such IDs are encountered, which will help identify the root cause of the issue.
Collaborator
|
Please fix this in #338, and close this PR. |
Author
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.