Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 93.82% 94.05% +0.22%
==========================================
Files 11 11
Lines 1701 1715 +14
==========================================
+ Hits 1596 1613 +17
+ Misses 72 69 -3
Partials 33 33
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for spotting the bug...
There was a problem hiding this comment.
On the call today, there was discussion on wanting "some number of additional unit tests" related to marshal and unmarshal.
This is vague, so any number of increases in unit tests would unblock my review.
I am requesting "additional unit tests" at the discretion of the maintainers.
|
@qmuntal to evaluate what additional tests are required to build confidence to merge. |
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
I've gone through the test suite of other COSE libraries, most notably https://github.com/google/coset, and I haven't found any outstanding missing case on our suite. IMO this is ready to merge. |
|
Thanks, @qmuntal |
fxamacker/cborrelease notes: https://github.com/fxamacker/cbor/releases/tag/v2.5.0.Fixes #165