Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion packages/core/e2e/facet.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { pick } from '@vendure/common/lib/pick';
import { FacetService, FacetValueService, RequestContextService } from '@vendure/core';
import { createTestEnvironment, E2E_DEFAULT_CHANNEL_TOKEN } from '@vendure/testing';
import path from 'path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';
import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest';

import { initialData } from '../../../e2e-common/e2e-initial-data';
import { TEST_SETUP_TIMEOUT_MS, testConfig } from '../../../e2e-common/test-config';
Expand Down Expand Up @@ -875,6 +875,50 @@ describe('Facet resolver', () => {
expect(value?.name).toBe('Original Value');
});
});

it('createFacetValue and createFacetValues do not load the existing values of the facet', async () => {
const { createFacet } = await adminClient.query(createFacetDocument, {
input: {
isPrivate: false,
code: 'speaker-power',
translations: [{ languageCode: LanguageCode.en, name: 'Speaker Power' }],
values: [
{
code: 'battery',
translations: [{ languageCode: LanguageCode.en, name: 'Battery' }],
},
],
},
});
const facetService = server.app.get(FacetService);
const findOne = vi.spyOn(facetService, 'findOne');
try {
await adminClient.query(createFacetValueDocument, {
input: {
facetId: createFacet.id,
code: 'mains',
translations: [{ languageCode: LanguageCode.en, name: 'Mains Powered' }],
},
});
await adminClient.query(createFacetValuesDocument, {
input: [
{
facetId: createFacet.id,
code: 'solar',
translations: [{ languageCode: LanguageCode.en, name: 'Solar Powered' }],
},
],
});

expect(findOne.mock.calls.length).toBe(2);
for (const [, , relations] of findOne.mock.calls) {
// `findOne()` loads `values` when no relations are passed
expect(relations ?? ['values']).not.toContain('values');
}
} finally {
findOne.mockRestore();
}
});
});

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/api/resolvers/admin/facet.resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export class FacetResolver {
): Promise<Array<Translated<FacetValue>>> {
const { input } = args;
const facetId = input[0].facetId;
const facet = await this.facetService.findOne(ctx, facetId);
const facet = await this.facetService.findOne(ctx, facetId, ['channels']);
if (!facet) {
throw new EntityNotFoundError('Facet', facetId);
}
Expand All @@ -161,7 +161,7 @@ export class FacetResolver {
@Args() args: MutationCreateFacetValueArgs,
): Promise<Translated<FacetValue>> {
const { input } = args;
const facet = await this.facetService.findOne(ctx, input.facetId);
const facet = await this.facetService.findOne(ctx, input.facetId, ['channels']);
if (!facet) {
throw new EntityNotFoundError('Facet', input.facetId);
}
Expand Down
Loading