Skip to content

Update google cloud storage docs #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dr-dimitru merged 2 commits into from
Jan 19, 2017
Merged

Update google cloud storage docs #330

dr-dimitru merged 2 commits into from
Jan 19, 2017

Conversation

@jeremywrnr
Copy link
Contributor

@jeremywrnr jeremywrnr commented Jan 17, 2017 •
edited
Loading

This is updating the google cloud example based on issue #292 and the resolution that was given there.

dr-dimitru and others added 2 commits December 15, 2016 18:55
@dr-dimitru
Merge pull request #310 from VeliovGroup/dev
076f5e0 
v1.7.6
 - NPM dependencies update
 - Support for updated *Buffer* API on node >= 6.*
 - Methods `addFile`, `write` and `load` now supports `userId` option, see #305
 - Fix for unfinished uploads, now files is removed by upload TTL. See #267, thanks to @ck23onGithub
 - Better FS-stream management on server. Less memory and CPU consumption. Only one descriptor per upload. Fix FS-permissions
 - `.unlink()` method now supports callback
 - Docs for [MUP/Docker integration](https://github.com/VeliovGroup/Meteor-Files/wiki/MeteorUp-(MUP)-Usage)
 - Fix #293
 - Fix #299
 - BEtter AWS dos, see #282
 - `storagePath` now always is function, if *String* is passed - it will be wrapped into function
 - Please participate at [this thread](#309) to give a right path for Meteor-Files v2.0
@jeremywrnr
update docs with google cloud api usage
fbfb501
@dr-dimitru
Copy link
Member

dr-dimitru commented Jan 17, 2017

Hello @jeremywrnr ,

Thank you for this PR.
Could you please describe changes.
Is API changed at Google Cloud end? Was this solution wrong from beginning?

@jeremywrnr
Copy link
Contributor Author

jeremywrnr commented Jan 17, 2017

Hi, and sure thing: based on what I found, the solution was wrong from the beginning: bucket.deleteFiles is meant to delete all the files in the bucket, so switching the method to be bucket.file(<name>).delete fixes the issue in the documentation.

Suggest getting added: googleapis/google-cloud-node#680
Adding deleteFiles: googleapis/google-cloud-node#698
Docs for deleteFiles: https://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/docs/master/storage/bucket?method=deleteFiles

@dr-dimitru dr-dimitru merged commit 776c12e into veliovgroup:dev Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremywrnr @dr-dimitru