Skip to content

Conversation

@jrmsklar
Copy link

This PR fixes a small typo in the word "incorrect".

@ziogaschr
Copy link
Collaborator

Thanks for the help @jrmsklar.

This PR is partially handled in #27.

Current PR is not backward compatible as it also changes maximumInccorectPasscodeAttempts which is a public property and it might brake current apps using this lib.

@jrmsklar
Copy link
Author

@ziogaschr gotchya 👍.

Will maximumInccorectPasscodeAttempts be updated in that other PR? I think it'd be beneficial to correct that even at the expense of developers updating that name when updating the pod.

@ziogaschr
Copy link
Collaborator

Will maximumInccorectPasscodeAttempts be updated in that other PR?

no, it won't.

@velikanov has a nice list with such typos #9.

I was thinking that we should wait for the next release, let's see what rest people think.

@jrmsklar
Copy link
Author

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants