-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(azure_blob sink)!: Update azure (0.25) and azure storage (0.21) #23351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as outdated.
This comment was marked as outdated.
1720078 to
ffe54be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change necessitates setting a connection_string so we should add a breaking changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thomas reviewed and we chatted offline
Summary
azure_coreandazure_identityto v0.25azure_storageandazure_storage_blobsto v0.21.azuriteversionconnection_stringis now mandatory and the only auth methodazure_blob_insert_lines_into_blob_gziptest (verified manually against a real Azure account)Rationale
This is part of the ongoing effort to update http to
1.x. Also, theazure_*crates updates have been buggy and introduced undocumented subtle behavior changes. We do want to support more authentications options once these crates mature. Some ideas are described here: #23036 (comment)Vector configuration
How did you test this PR?
Verified manually against a real Azure account.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Related: #19179
Related: Metaswitch/apt-transport-blob#77
Related: #22917
Related: #23036
Related: #22912
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)git merge origin masterandgit push.Cargo.lock), pleaserun
cargo vdev build licensesto regenerate the license inventory and commit the changes (if any). More details here.