Skip to content

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Jul 9, 2025

Summary

  • Update azure_core and azure_identity to v0.25
  • Update azure_storage and azure_storage_blobs to v0.21.
  • Update azurite version
  • Breaking: connection_string is now mandatory and the only auth method
  • Ignores azure_blob_insert_lines_into_blob_gzip test (verified manually against a real Azure account)

Rationale

This is part of the ongoing effort to update http to 1.x. Also, the azure_* crates updates have been buggy and introduced undocumented subtle behavior changes. We do want to support more authentications options once these crates mature. Some ideas are described here: #23036 (comment)

Vector configuration

How did you test this PR?

Verified manually against a real Azure account.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #19179
Related: Metaswitch/apt-transport-blob#77
Related: #22917
Related: #23036
Related: #22912

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@thomasqueirozb thomasqueirozb requested a review from a team as a code owner July 9, 2025 20:50
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jul 9, 2025
@thomasqueirozb thomasqueirozb added sink: azure_blob Anything `azure_blob` sink related no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jul 9, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch. This should help with:

@datadog-vectordotdev

This comment was marked as outdated.

@pront pront force-pushed the master branch 4 times, most recently from 1720078 to ffe54be Compare July 10, 2025 15:43
@pront pront marked this pull request as draft July 10, 2025 16:43
pront
pront previously requested changes Jul 17, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This change necessitates setting a connection_string so we should add a breaking changelog.

@thomasqueirozb thomasqueirozb removed the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 23, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Sep 4, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 186268e | Docs | Was this helpful? Give us feedback!

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Sep 4, 2025
@pront pront marked this pull request as ready for review September 4, 2025 19:59
@pront pront changed the title chore(deps): Update azure (0.25) and azure storage (0.21) chore!(deps): Update azure (0.25) and azure storage (0.21) Sep 4, 2025
@pront pront requested a review from a team as a code owner September 4, 2025 20:20
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Sep 4, 2025
@pront pront changed the title chore!(deps): Update azure (0.25) and azure storage (0.21) chore(azure_blob sink)!: Update azure (0.25) and azure storage (0.21) Sep 4, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas reviewed and we chatted offline

@pront pront enabled auto-merge September 5, 2025 13:03
@pront pront added this pull request to the merge queue Sep 5, 2025
@pront pront removed this pull request from the merge queue due to a manual request Sep 5, 2025
@pront pront enabled auto-merge September 5, 2025 13:35
@pront pront added this pull request to the merge queue Sep 5, 2025
Merged via the queue into master with commit 09461c9 Sep 5, 2025
86 checks passed
@pront pront deleted the azure-deps-0.25 branch September 5, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks sink: azure_blob Anything `azure_blob` sink related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants