-
Notifications
You must be signed in to change notification settings - Fork 1.9k
enhancement(gcp_pubsub sink, codecs)!: Integrate encoding::Encoder with gcp_pubsub sink
#12718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(gcp_pubsub sink, codecs)!: Integrate encoding::Encoder with gcp_pubsub sink
#12718
Conversation
👷 Deploy Preview for vector-project processing.
|
👷 Deploy Preview for vector-project processing.
|
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2927ced to
83c5d92
Compare
Signed-off-by: Pablo Sichert <[email protected]>
83c5d92 to
9eedd64
Compare
jszwedko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note to the upgrade guide since this is a breaking change?
|
Also, why is it no longer optional? Could we maintain the existing default? |
Largely to be consistent with all the other sinks. Previously there only existed a default here because the user had no choice at all. So I'm not sure it's worth to break consistency to remain backwards compatible here, especially since the migration path is very straight-forward. |
encoding::Encoder with gcp_pubsub sinkencoding::Encoder with gcp_pubsub sink
…gcp_pubsub-codec-integration Signed-off-by: Pablo Sichert <[email protected]>
Signed-off-by: Pablo Sichert <[email protected]>
Signed-off-by: Pablo Sichert <[email protected]>
…gcp_pubsub-codec-integration Signed-off-by: Pablo Sichert <[email protected]>
jszwedko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the upgrade note. Do we need to update the docs too? Currently that option is undocumented for this sink.
Signed-off-by: Pablo Sichert <[email protected]>
jszwedko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
Soak Test ResultsBaseline: b471333 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
Part of #9459.
This is a breaking change since the
encodingis no longer optional.