-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
domain: codecsAnything related to Vector's codecs (encoding/decoding)Anything related to Vector's codecs (encoding/decoding)domain: sinksAnything related to the Vector's sinksAnything related to the Vector's sinkstype: taskGeneric non-code related tasksGeneric non-code related tasks
Description
Once #9459 is completed, we can follow up to remove the EncodingConfigAdapter and legacy EncodingConfigs.
These are currently needed to integrate the new Encoder with sinks without breaking backwards-compatibility. However at the expense of bad error messages when the config is malformed/invalid:
- the serde
deny_unkown_fieldsattribute doesn't work in combination withflattenand untagged enums (deny_unknown_fields incorrectly fails with flattened untagged enum serde-rs/serde#1600), therefore additional "junk" is not rejected from configs - untagged enums in serde currently don't report detailed errors: Collect errors when deserializing untagged enums serde-rs/serde#1544
jszwedko
Metadata
Metadata
Assignees
Labels
domain: codecsAnything related to Vector's codecs (encoding/decoding)Anything related to Vector's codecs (encoding/decoding)domain: sinksAnything related to the Vector's sinksAnything related to the Vector's sinkstype: taskGeneric non-code related tasksGeneric non-code related tasks