Move a few more functions into namespaces, remove TConfiguration template parameter
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities
Moved them out of the global namespace, to reduce the chance of name collisions.
N-Dekker
force-pushed
the
namespaces-and-Configuration
branch
2 times, most recently
from
2f4b4cc to
bae33bf
Compare
It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
N-Dekker
force-pushed
the
namespaces-and-Configuration
branch
from
bae33bf to
488609b
Compare
Author
|
@vboussot If you agree, you may just squash these three commits with your feature branch. No need to preserve the separate commits. |
vboussot
pushed a commit
that referenced
this pull request
May 14, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Jul 1, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Oct 11, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Oct 13, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Oct 15, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
vboussot
pushed a commit
that referenced
this pull request
Nov 23, 2025
…ion` template parameter (#2) * STYLE: Move helper functions of elxImpactMetricGTest into namespace Following C++ Core Guidelines, Oct 3, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities * STYLE: Place elxImpactMetric functions into elastix namespace Moved them out of the global namespace, to reduce the chance of name collisions. * STYLE: Remove `Configuration` template parameters It appears unnecessary for formatParameterStringByDimensionAndLevel to have `Configuration` as template parameter, because elastix only has one `Configuration` type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vboussot Hereby three small style improvements, please correct me if I'm wrong 😃
elastixnamespace, to reduce the chance of name collisionsTConfigurationtemplate parameters from formatParameterStringByDimensionAndLevel, because elastix only has oneConfigurationtype