-
Notifications
You must be signed in to change notification settings - Fork 8.3k
feat: add theme-aware logo support via optional sourceDark configuration #6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Co-authored-by: aonoa <[email protected]>
Co-authored-by: aonoa <[email protected]>
Co-authored-by: aonoa <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
@copilot /**
|
|
8abe4ab to
46f60b1
Compare
|
@copilot 为登陆页的logo也加上随主题切换的功能 |
Co-authored-by: aonoa <[email protected]>
Signed-off-by: aonoa <[email protected]>


Summary
This PR implements support for configuring separate logo images for light and dark themes, solving the issue where solid color icons (such as black) display normally in light theme but blend with the background color in dark theme.
📋 Changes Made
Type Definitions
sourceDarkfield toLogoPreferencesinterfaceLogo Component Enhancement
VbenLogocomponent to acceptsrcDarkprop:keyattribute to VbenAvatar to ensure re-rendering when logo changessrcwhensourceDarknot providedAuthentication Page Support
logoDarkprop toAuthPageLayoutcomponentisDark):keyattribute to login page logo for smooth theme transitionsLayout Integration
sourceDarkto all logo instancesDocumentation
sourceDarkfield💡 Usage Example
The logo will automatically switch between light and dark versions on both the login page and main application layout when users toggle the theme.
✅ Testing & Validation
🔄 Backward Compatibility
sourceDarkis optional - defaults tosourceif not specified🐛 Bug Fixes
:key="logoSrc"to the VbenAvatar component📸 Screenshots
Login page - Light theme:

Login page - Dark theme:

The logo automatically switches between appropriate versions when the user toggles the theme on the login page.
🔒 Security Summary
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.