Conversation
Fix default embedding model used with PGVector
Removed redundant method declaration in PGVector; update PGVector unit tests
|
All of @andreped's changes are now merged into this PR and I think it is ready to merge. |
The tests are passing for me, I made a small change to bring in the database port from an environment variable. |
|
I commented out the tests because I'm getting a bunch of dependency issues trying to run them. We can add them back later |
|
No worries, @zainhoda. As we already talked about, I can make a PR to add these tests in a more proper way, such that they will not conflict with the tests you are already running on your end (potentially not in GitHub Actions). You should be able to test individual components easily without the full blown tests. |
Fixes for #659
@andreped could you take a look?